[FFmpeg-devel] [PATCH] avfilter/showcqt: BASEFREQ and ENDFREQ cast to double

Nicolas George george at nsup.org
Mon Nov 30 16:52:20 CET 2015

Le decadi 10 frimaire, an CCXXIV, Muhammad Faiz a écrit :
> -    if (s->basefreq != BASEFREQ || s->endfreq != ENDFREQ) {
> +    if (s->basefreq != (double) BASEFREQ || s->endfreq != (double) ENDFREQ) {

Looks wrong to me. Since s->basefreq is double and operands are always
converted to the largest type before comparison, the cast would be implicit.
And BASEFREQ and ENDFREQ are double anyway.

The problem, if any, is somewhere else.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151130/37c81014/attachment.sig>

More information about the ffmpeg-devel mailing list