[FFmpeg-devel] [PATCH]lavf/shortendec: Autodetect raw Shorten streams.

[Michael Niedermayer]

On Fri, Oct 02, 2015 at 01:05:50PM +0200, Carl Eugen Hoyos wrote:
> On Friday 02 October 2015 12:48:17 pm Paul B Mahol wrote:
> > On 10/2/15, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > > Hi!
> > >
> > > Attached patch implements Shorten auto-detection.
> > >
> > > Please comment, Carl Eugen
> >
> > You do not check byte size
> 
> I thought both the safe bitstream reader and the minimal 
> probe buffer size avoid an overread here.
> Is that wrong?
> 
> > and not using init_get_bits8. 
> 
> Fixed, thank you!
> 
> New patch attached, Carl Eugen

>  Makefile     |    2 -
>  rawdec.c     |   12 ---------
>  shortendec.c |   71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  version.h    |    2 -
>  4 files changed, 73 insertions(+), 14 deletions(-)
> 5c59131e01c4a4e864963890fdebf635eeb1df3c  patchshn.diff

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151003/32f14ffe/attachment.sig>