[FFmpeg-devel] [PATCH 1/2] avfilter/all: propagate errors of functions from avfilter/formats

[Ronald S. Bultje]

Hello,

On Mon, Oct 5, 2015 at 3:43 PM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:

> Hi,
>
> I have attached the patch.


>      // inlink supports any channel layout
>      layouts = ff_all_channel_counts();
> -    ff_channel_layouts_ref(layouts, &inlink->out_channel_layouts);
> +    if (!layouts)
> +        return AVERROR(ENOMEM);
> +    if ((ret = ff_channel_layouts_ref(layouts,
&inlink->out_channel_layouts)) < 0) {
> +        ff_channel_layouts_unref(&layouts);
> +        return ret;
> +    }

I already feel fully inadequate to review this patch :-D. But this looks
weird. My proposal is that someone familiar with avfilter review this.
Nicolas, Clement, Stefano, Michael, Paul, (I probably forgot some people,)
can one of you volunteer?

Ronald