[FFmpeg-devel] [PATCH 01/10] lavu: add AESNI CPU flag

[Michael Niedermayer]

On Tue, Oct 13, 2015 at 02:46:55PM +0200, Moritz Barsnick wrote:
> On Tue, Oct 13, 2015 at 04:27:07 +0200, Michael Niedermayer wrote:
> > > @@ -117,6 +117,7 @@ static const struct {
> > >      { "SSSE3",    "ssse3",    AV_CPU_FLAG_SSSE3|AV_CPU_FLAG_ATOM },
> > >      { "SSE4.1",   "sse4",     AV_CPU_FLAG_SSE4 },
> > >      { "SSE4.2",   "sse42",    AV_CPU_FLAG_SSE42 },
> > > +    { "AES-NI",   "aesni",    AV_CPU_FLAG_AESNI },
> > 
> > not 100% sure its this but the - looks like invalid syntax
> > -, +, *, /, ... should be avoided
> 
> In this case, isn't this just a string used in print_cpu_name()?

maybe it was the aes-ni in
static const AVOption cpuflags_opts[] =
that caused the issue


> 
> BTW, Henrik Gramner pointed out yesterday:
> 
> > Should be "AES-NI" with a dash here since that's the official name,
> > possibly in a few other places as well (using a dash wherever SSE4.1
> > is spelled with dot is probably reasonable).
> 
> And Rodger didn't even change it everywhere possible (commit message,
> configure output). ;-)
> 
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151013/c1a679f0/attachment.sig>