[FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched

[Vicente Olivert Riera]

Dear Nedeljko Babic,

On 10/15/2015 01:05 PM, Nedeljko Babic wrote:
> Hello,
> 
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
>> ---
>> configure |    9 +++++++++
>> 1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 7e55e92..cd27ad7 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4130,6 +4130,15 @@ elif enabled mips; then
>>             disable mips64r6
>>             disable msa
>>         ;;
>> +        *)
>> +            disable mipsfpu
>> +            disable mips32r2
>> +            disable mips32r5
>> +            disable mips64r6
>> +            disable mipsdspr1
>> +            disable mipsdspr2
>> +            disable msa
>> +        ;;
>>     esac
> 
> This case will never be reached.
> 
> If configure  “--cpu” option is not used, default is cpu=generic.
> 
> On the other hand, if cpu option is used with some cpu that is not supported in
>  the list, configuration will break since “-march” is set to that cpu value.

Are you sure? What happen if you pass --cpu=mips32r2? Then -march will
be set to mips32r2 which is valid :-)

Regards,

Vincent.

>>
>> elif enabled ppc; then
> 
> -Nedeljko
>