[FFmpeg-devel] [PATCHv2] all: fix enum definition for large values
Michael Niedermayer
michael at niedermayer.cc
Wed Oct 28 03:23:57 CET 2015
On Tue, Oct 27, 2015 at 08:53:39PM -0400, Ganesh Ajjanagadde wrote:
> ISO C restricts enumerator values to the range of int. Thus (for instance) 0x80000000
> unfortunately does not work, and throws a warning with -Wpedantic on
> clang 3.7.
>
> This fixes it by using alternative expressions that result in identical
> values but do not have this issue.
>
> Tested with FATE.
>
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
> libavcodec/dca_syncwords.h | 26 ++++++++++++--------------
> libavformat/cinedec.c | 2 +-
> libavformat/mov_chan.c | 2 +-
> 3 files changed, 14 insertions(+), 16 deletions(-)
LGTM (good in the sense of fixing the issue not neccessrily good as
in pretty)
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151028/02f757d9/attachment.sig>
More information about the ffmpeg-devel
mailing list