[FFmpeg-devel] [PATCH][RFC] libavformat/mov Extend metadata handling to read in the keys from the 'keys' atom

Kevin Wheatley kevin.j.wheatley at gmail.com
Fri Sep 4 11:53:53 CEST 2015


On Thu, Sep 3, 2015 at 7:49 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> missing checks for interger overflows of the addition and subtraction
>
> also the subject says "RFC", is there a reason not to push this to
> git master once it otherwise looks good ?


it is incomplete, basically I was fishing for a general OK to (ab)use
the dictionary in the MOVContext as a means to pass on the list of
keys, having done that, I've moved on to extend the data types
understood to include other data types (The sample ARRI clips need
signed and unsigned integers). I have this working but the code is in
need of a refactoring to say the least.

There does not appear to be a way to indicate the 'type' of data
pushed into the dictionary so that if I wanted to serialise it back
out I could get the same format, is this something people have
considered?

I could use a type dictionary to store the original type of the keys
along side the standard metatdata dictionary, but how that would feed
into the metatdata mux/demuxing and the command line interface I don't
know.

Thanks

Kevin


More information about the ffmpeg-devel mailing list