[FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)

Michael Niedermayer michaelni at gmx.at
Sat Sep 12 20:28:52 CEST 2015

On Sat, Sep 12, 2015 at 03:25:05PM -0300, James Almer wrote:
> On 9/12/2015 3:04 PM, Carl Eugen Hoyos wrote:
> > Hi!
> > 
> > Attached patch implements making probesize and analyzeduration 64bit 
> > unless api compatibility was requested.
> > 
> > I will add a line to doc/APIchanges and do a minor version bump.
> > 
> > Please review, this cannot wait, Carl Eugen
> You're removing probesize2 and max_analyze_duration2, which supposedly
> were added to replace the deprecated probesize and max_analyze_duration
> fields, all while undeprecating the latter in the meantime.
> The FF_API_PROBESIZE_32 wrapper is faulty as well to begin with. It's
> scheduling the removal of probesize2 and max_analyze_duration2, which
> are supposedly the non-deprecated replacements.

probesize2 and max_analyze_duration2 are documented as
"NO direct access"
so API wise these 2 fields should be fine to remove from the struct

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150912/fc5550fa/attachment.sig>

More information about the ffmpeg-devel mailing list