[FFmpeg-devel] [PATCH]Bump probesize and analyzeduration to 64bit (again)
michaelni at gmx.at
Sat Sep 12 20:42:36 CEST 2015
On Sat, Sep 12, 2015 at 03:37:08PM -0300, James Almer wrote:
> On 9/12/2015 3:28 PM, Michael Niedermayer wrote:
> > On Sat, Sep 12, 2015 at 03:25:05PM -0300, James Almer wrote:
> >> On 9/12/2015 3:04 PM, Carl Eugen Hoyos wrote:
> >>> Hi!
> >>> Attached patch implements making probesize and analyzeduration 64bit
> >>> unless api compatibility was requested.
> >>> I will add a line to doc/APIchanges and do a minor version bump.
> >>> Please review, this cannot wait, Carl Eugen
> >> You're removing probesize2 and max_analyze_duration2, which supposedly
> >> were added to replace the deprecated probesize and max_analyze_duration
> >> fields, all while undeprecating the latter in the meantime.
> >> The FF_API_PROBESIZE_32 wrapper is faulty as well to begin with. It's
> >> scheduling the removal of probesize2 and max_analyze_duration2, which
> >> are supposedly the non-deprecated replacements.
> > probesize2 and max_analyze_duration2 are documented as
> > "NO direct access"
> > so API wise these 2 fields should be fine to remove from the struct
> "NO direct access" will now apply to the new max_analyze_duration and
> probesize fields when incompatible-libav-abi is not used. Is that intended?
> If so then it should be ok.
> We could also wait for the final decision about abi compatibility and just
> make this change without the AV_HAVE_INCOMPATIBLE_LIBAV_ABI check, but that
> can be removed in a different commit as well i guess.
I think theres consense about "abi compatibility" so i would tend to
suggest to move forward with that in mind.
The open points seemed about details IIUC which IMHO should not hold
things up, especially as the code after the bump isnt exactly ABI
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel