[FFmpeg-devel] [PATCH] avcodec/dvenc: silence -Wdiscarded-qualifiers
u at pkh.me
Sun Sep 20 12:00:20 CEST 2015
On Sat, Sep 19, 2015 at 07:08:01PM -0400, Ganesh Ajjanagadde wrote:
> s->frame is non-const, so this casts them explicitly.
> This suppresses -Wdiscarded-qualifiers seen in e.g
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> libavcodec/dvenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c
> index 5de12cc..0f4daa1 100644
> --- a/libavcodec/dvenc.c
> +++ b/libavcodec/dvenc.c
> @@ -721,7 +721,7 @@ static int dvvideo_encode_frame(AVCodecContext *c, AVPacket *pkt,
> return ret;
> c->pix_fmt = s->sys->pix_fmt;
> - s->frame = frame;
> + s->frame = (AVFrame *) frame;
Just a note here: I see you tend to like "(type *) var" style. I honestly
don't mind that much, but keep in mind the common way is to stick the var
to the cast (for various reasons such as consistency with most of the
current code base but also because it makes more sense semantically as
well as avoiding confusion with more complex expressions).
Feel free to commit as is, I won't raise it again, I'm just trying to
prevent an introduction of a more "distributed" code style.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
Desc: not available
More information about the ffmpeg-devel