[FFmpeg-devel] [PATCH 3/3] lavf/hls: allow subtitles to be read despite incomplete handling

[wm4]

On Sun, 20 Sep 2015 21:55:35 -0500
Rodger Combs <rodger.combs at gmail.com> wrote:

> This will give incorrect results in some cases due to not parsing segments
> separately, but it works well enough in general that it seems worth enabling.
> ---
>  libavformat/hls.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index a5073ff..74af300 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -391,10 +391,6 @@ static struct rendition *new_rendition(HLSContext *c, struct rendition_info *inf
>      if (type == AVMEDIA_TYPE_SUBTITLE && !info->uri[0])
>          return NULL;
>  
> -    /* TODO: handle subtitles (each segment has to parsed separately) */
> -    if (type == AVMEDIA_TYPE_SUBTITLE)
> -        return NULL;
> -
>      rend = av_mallocz(sizeof(struct rendition));
>      if (!rend)
>          return NULL;

Before muxing possibly invalid streams by default, this should probably
require setting some sort of experimental flag (not sure if we have
such a thing in libavformat).