[FFmpeg-devel] [PATCH] ffplay: fix silence insertion on error or pause

[Marton Balint]

On Mon, 4 Apr 2016, Lukasz Marek wrote:

> On 03.04.2016 21:37, Marton Balint wrote:
>> Insertion of silence was a bit broken since
>> df34b700981de606ca4847e1ed0bfdf9ac3e9104 because the info whether or not the
>> source buffer supposed to be silence must be kept between callbacks. Failing to
>> do so causes rogue samples from the last buffer to be presented, I guess even a
>> crash can occur under some circumstances.
>> 
>> This patch uses a NULL audio_buf to keep the silence state across audio
>> callbacks.
>> 
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  ffplay.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> mea culpa

No problem, I missed it too :)

> LGFM

Thanks, pushed.

Regards,
Marton