[FFmpeg-devel] [PATCH 12/13] lavc/videotoolboxenc: Support pixel aspect ratio

[Richard Kern]

> On Apr 10, 2016, at 12:24 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> 
> Rick Kern <kernrj <at> gmail.com> writes:
> 
>> +        if (status) {
>> +            av_log(
>> +                   avctx,
>> +                   AV_LOG_ERROR,
>> +                   "Error setting pixel aspect ratio to %d:%d: %d.\n",
> 
> Why would the function call fail?
> 
> I would expect that the pixel aspect ratio has max 
> values, if yes, you first have to av_reduce the sar.
Some encoders enforce specific pixel aspect ratios. The vt docs don’t mention a max value, but I’ll call av_reduce.

> 
>> +                   avctx->sample_aspect_ratio.num,
>> +                   avctx->sample_aspect_ratio.den,
>> +                   status);
>> +
>> +            return AVERROR_EXTERNAL;
> 
> In any case, printing the error should be enough imo.
> 
> Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel