[FFmpeg-devel] [PATCH v2] Add "sar" alias to "aspect" option of video encoders

Carl Eugen Hoyos ceffmpeg at gmail.com
Mon Aug 8 22:41:06 EEST 2016


2016-08-08 20:58 GMT+02:00 Andrey Utkin <andrey_utkin at fastmail.com>:
> On Thu, Jul 14, 2016 at 05:27:08PM +0000, Carl Eugen Hoyos wrote:
>> Andrey Utkin <andrey_utkin <at> fastmail.com> writes:
>>
>> > It is impossible to pass "aspect" parameter to encoder from ffmpeg
>> > CLI because option from lavc/options_table.h is eclipsed by option
>> > with same name in ffmpeg_opt.c, which has different meaning (DAR,
>> > not SAR).
>>
>> Wasn't the old behaviour intended because it assured you cannot
>> pass contradicting options to the libraries via ffmpeg?
>
> I don't think so.
> Proper way to avoid contradiction is explicit check in code.

Where can this be checked?

> It is a usability flaw to be unable to pass certain encoder option in
> CLI while all other are passed finely.

But in which situation (which command line) could you not set the
aspect correctly before your patch?

Carl Eugen


More information about the ffmpeg-devel mailing list