[FFmpeg-devel] [PATCH 1/2] avformat/dvbtxt: add raw demuxer for dvb teletext probing

Carl Eugen Hoyos cehoyos at ag.or.at
Tue Feb 16 21:51:36 CET 2016


Marton Balint <cus <at> passwd.hu> writes:

> >> +    return AVPROBE_SCORE_MAX / 2;
> >
> > Is this ok for one frame?
> 
> I don't know, I figured even for the smallest PES 
> payload which is 139 bytes we are matching 1+2+2+2 
> mostly different bytes

Then the score is ok (or too small).

> >> +++ b/libavutil/internal.h
> >
> > Please create a new teletext header in libavcodec.
> 
> Why not in libavutil then?

Because it is far too specific for libavutil.

> It is used in a codec in libavcodec and a probe 
> function in libavformat.

This means it should be in libavcodec.

Carl Eugen



More information about the ffmpeg-devel mailing list