[FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

[Moritz Barsnick]

On Fri, Feb 19, 2016 at 17:51:00 +0100, Nicolas George wrote:
> Changing the name of existing muxers is annoying, but for new features I
> would like much better if we did not wave around the name of a hash function
> that has known vulnerabilities since 20 years: "streamhash" would be an
> obvious choice.

I would like to propose a (quite trivial) patch renaming first the
sources, then the muxers, and of course aliasing the existing muxer
names.

But before that:

> > +static const AVClass streammd5enc_class = {
> > +    .class_name = "stream hash encoder class",
> > +    .item_name  = av_default_item_name,
> 
> > +    .option     = hash_options,
> 
> I am rather surprised to see that the existing code uses the same options
> array for both md5 and framemd5, I thought it was not allowed.
> 
> But anyways, md5 and framemd5 both use the same MD5Context. Using the same
> options array with a different context structure is a big no.

I don't quite understand: Is there something that needs to be fixed in
the existing md5enc code?

And are there some written guideline on these sorts of things, or is it
"obvious" or just "from experience"?

Thanks!
Moritz