[FFmpeg-devel] [PATCH] avcodec/put_bits: Always check buffer end before writing

Michael Niedermayer michael at niedermayer.cc
Sat Jan 2 19:34:53 CET 2016


On Fri, Jan 01, 2016 at 04:10:29PM +0100, Michael Niedermayer wrote:
> From: Michael Niedermayer <michael at niedermayer.cc>
> 
> This causes a overall slowdown of 0.1 % (tested with mpeg4 single thread encoding of matrixbench at QP=3)
> 
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/put_bits.h |   20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160102/0ad7c97a/attachment.sig>


More information about the ffmpeg-devel mailing list