[FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Mon Jan 11 23:18:43 CET 2016


On 10.01.2016 13:03, Mats Peterson wrote:
> On 01/10/2016 11:56 AM, Andreas Cadhalpun wrote:
>> This fixes segmentation faults due to out of bounds writes, when
>> color_start is interpreted as negative number.
>>
> Yes Andreas, until my normalization patch for matroskadec.c is applied, of course
> it's very easy for these variables to be negative when using an int, because of
> the invalid private data. I stand corrected.

It can probably also happen with matroska files, but I saw it crash with
a mov file.

In any case, I pushed the patch now.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list