[FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)

Ronald S. Bultje rsbultje at gmail.com
Tue Jan 19 14:51:15 CET 2016


Hi,

On Tue, Jan 19, 2016 at 8:42 AM, Mats Peterson <
matsp888-at-yahoo.com at ffmpeg.org> wrote:

> On 01/19/2016 02:40 PM, Ronald S. Bultje wrote:
>
>> We tend to indent the second line so it aligns with the opening bracket of
>> the first line.
>>
>
> Excuse me if i chime in here, Ronald,  yes, I've noticed that as well.
> However, sometimes it can be quite awkward to do this alignment when having
> a lot of stuff before the opening bracket, and lots of parameters.


What I did in vp8 (if I remember correctly) in those cases is to split the
top line:

static av_always_inline long_return_type_name
far_too_long_function_name(type arg1, type arg2,
                           type arg3, type arg4)
{
    ..
}

May be helpful, but all of this is very personal-taste-ish...

Ronald


More information about the ffmpeg-devel mailing list