[FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (v2)

[Michael Niedermayer]

On Fri, Jan 22, 2016 at 12:32:00PM +0000, John Cox wrote:
> On Fri, 22 Jan 2016 01:57:58 +0100, you wrote:
> 
> >On Fri, Jan 22, 2016 at 01:41:11AM +0100, Michael Niedermayer wrote:
> >> On Thu, Jan 21, 2016 at 10:45:55AM +0000, John Cox wrote:
> >> > Hi
> >> > 
> >> > v2 of my hevc residual patch
> >> > 
> >> > I've fixed the fate regression
> >> > I've split it into more pieces
> >> > Now uses ff_clz
> >> > Some reformating of function headers
> >> > 
> >> > The patches can also be found on
> >> > https://github.com/jc-kynesim/rpi-ffmpeg.git on branch
> >> > test/ff_hevc_cabac_4 from tag ff_hevc_cabac_4_base
> >> > 
> >> > Note that I will be going on holiday from the end of Friday (UK time)
> >> > till the 1st Feb and will be unable to edit code or read this list
> >> > during that period.
> >> 
> >> seems failing here (with qemu)
> >>  --cc='ccache arm-linux-gnueabi-gcc-4.5' --extra-cflags='-mfpu=neon -mfloat-abi=softfp' --cpu=cortex-a8 --arch=armv7 --target-os=linux --enable-cross-compile --disable-iconv --disable-pthreads --enable-neon-clobber-test
> >> tried without --enable-neon-clobber-test too
> >> 
> >> qemu-arm version 1.1.0, Copyright (c) 2003-2008
> >> also tried qemu-arm version 1.6.50
> >> 
> >> arm-linux-gnueabi-gcc-4.5 (Ubuntu/Linaro 4.5.3-12ubuntu2) 4.5.3
> >> 
> >> also tried your branch
> >
> >fate-hevc passes with patch 1-5, so the issue is likely in the last
> >
> >[...]
> 
> Yup - bug in the arm update_rice (again - sorry).  Now passes fate on
> ARM too (now I've learnt how to run fate on my Pi in a finite time).
> 
> New version of patch 6 attached - all others should still be good

fate passes on qemu now
also you may want to add yourself to the MAINTAINERs file (in a patch)
for the parts you added

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160122/69bde4eb/attachment.sig>