[FFmpeg-devel] [PATCH] avcodec: split off synth_filter

[James Almer]

On 1/24/2016 6:41 PM, Hendrik Leppkes wrote:
> On Sun, Jan 24, 2016 at 9:53 PM, James Almer <jamrial at gmail.com> wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> This should make replacing the current dca decoder for foo86's easier, without
>> having to disable/reenable the compilation of synth_filter files in between
>> removal/addition commits.
>>
> 
> While it would make the  migration easier, the synth filter is purely
> a dca concept, is it not? Would it have any chance of being useful for
> anything else ever again?
> If the answer is no, spinning it out seems like a bit of overkill, but
> if you think its useful I won't object to it either way.

It wouldn't be the first. See iirfilter and how it's used by aac_encoder
only, or tpeldsp and svq3_decoder.

The context, the functions and most of the files were already separated
from dca, so it's IMO cleaner to have it this way.