[FFmpeg-devel] [PATCH] fix few compiler warnings

[Davinder Singh]

On Thu, Jun 2, 2016 at 5:18 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Sun, May 22, 2016 at 01:51:05AM +0000, Davinder Singh wrote:
> [...]
>
> >  vf_hwdownload.c |    6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 5eb7416fececde847414f37de9a78a4e1cd5e1af
> 0004-libavfilter-vf_hwdownload-show-error-when-ff_formats.patch
> > From d1d00989a374facba3cdf777d95c61bf385f1332 Mon Sep 17 00:00:00 2001
> > From: dsmudhar <ds.mudhar at gmail.com>
> > Date: Sun, 22 May 2016 06:26:36 +0530
> > Subject: [PATCH 4/7] libavfilter/vf_hwdownload: show error when
> ff_formats_ref
> >  fails
> >
> > ---
> >  libavfilter/vf_hwdownload.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavfilter/vf_hwdownload.c b/libavfilter/vf_hwdownload.c
> > index 2dcc9fa..79ea82d 100644
> > --- a/libavfilter/vf_hwdownload.c
> > +++ b/libavfilter/vf_hwdownload.c
> > @@ -56,8 +56,10 @@ static int hwdownload_query_formats(AVFilterContext
> *avctx)
> >          }
> >      }
> >
> > -    ff_formats_ref(infmts,  &avctx->inputs[0]->out_formats);
> > -    ff_formats_ref(outfmts, &avctx->outputs[0]->in_formats);
> > +    if ((err = ff_formats_ref(infmts,  &avctx->inputs[0]->out_formats))
> < 0 ||
> > +        (err = ff_formats_ref(outfmts, &avctx->outputs[0]->in_formats))
> < 0)
> > +        return err;
>
> according to coverity this introduces a memleak
> (1362184)
> ill send you an invite so you can take a look
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Those who are too smart to engage in politics are punished by being
> governed by those who are dumber. -- Plato
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


this patch should fix it

Thanks,
DSM_
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vf_hwdownload-fix-memory-leak.patch
Type: application/octet-stream
Size: 1296 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160603/88c97404/attachment.obj>