[FFmpeg-devel] [PATCH] nvenc: add an option to embed A53 closed captions

Hendrik Leppkes h.leppkes at gmail.com
Sat Jun 4 18:29:39 CEST 2016


On Sat, Jun 4, 2016 at 5:48 PM, Andrey Turkin <andrey.turkin at gmail.com> wrote:
>
> It mimics same options in libx264 and qsv_h264 encoders
> ---
>  libavcodec/internal.h    | 15 +++++++++
>  libavcodec/libx264.c     | 49 ++++++++++-------------------
>  libavcodec/nvenc.c       | 28 +++++++++++++++--
>  libavcodec/nvenc.h       |  1 +
>  libavcodec/nvenc_h264.c  |  1 +
>  libavcodec/nvenc_hevc.c  |  1 +
>  libavcodec/qsvenc.c      |  4 +--
>  libavcodec/qsvenc_h264.c | 82 +++++++++++++++---------------------------------
>  libavcodec/utils.c       | 44 ++++++++++++++++++++++++++
>  9 files changed, 131 insertions(+), 94 deletions(-)
>

Refactoring the existing a53cc functionality and extending it to a new
encoder should ideally be done in separate commits. Could you split
that?
I didn't review the actual changes beyond that yet.

- Hendrik


More information about the ffmpeg-devel mailing list