[FFmpeg-devel] [PATCH] lavf: add libopenmpt demuxer

Carl Eugen Hoyos cehoyos at ag.or.at
Sun Jun 12 10:05:48 CEST 2016


Josh de Kock <josh <at> itanimul.li> writes:

> +    if (p->buf[1080] == 'M' && p->buf[1081] == '.' &&
> +        p->buf[1082] == 'K' && p->buf[1083] == '.')
> +        return AVPROBE_SCORE_MAX;

This should return EXTENSION + 1 when testing 32bit.

> +    openmpt->channels = openmpt_module_get_num_channels(openmpt->module);

If known, please also set the channel_layout.

And consider to wait for a real review.

Thank you, Carl Eugen



More information about the ffmpeg-devel mailing list