[FFmpeg-devel] Fix memory leaks in segment muxer

Michael Niedermayer michael at niedermayer.cc
Mon Jun 20 19:42:26 CEST 2016


On Mon, Jun 20, 2016 at 05:24:04PM +0200, sebechlebskyjan at gmail.com wrote:
> From: Jan Sebechlebsky <sebechlebskyjan at gmail.com>
> 
> Hello,
> I've observed several memory leaks in segment muxer in case the
> failure happens in seg_init (write_header call). 
> I'm sending patchset to fix those.
> 
> Regards,
> Jan
> 
> Jan Sebechlebsky (3):
>   avformat/segment: Check write_header return value immediately
>   avformat/segment: Ensure write_trailer is called
>   avformat/segment: Use deinit function to deinitialize muxer
> 
>  libavformat/segment.c | 68 ++++++++++++++++++++++++++++-----------------------
>  1 file changed, 37 insertions(+), 31 deletions(-)

seems to cause:
libavformat/segment.c: In function ‘seg_write_trailer’:
libavformat/segment.c:944:29: warning: unused variable ‘next’ [-Wunused-variable]
libavformat/segment.c:944:23: warning: unused variable ‘cur’ [-Wunused-variable]

no more comments from me, review left to others

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160620/592874aa/attachment.sig>


More information about the ffmpeg-devel mailing list