[FFmpeg-devel] [PATCH 1/3] h264_ps: change decode_scaling_matrices so that it takes

[Michael Niedermayer]

On Tue, Jun 28, 2016 at 09:23:14AM +0200, Benoit Fouet wrote:
> Hi,
> 
> On 27/06/2016 18:31, Michael Niedermayer wrote:
> >On Mon, Jun 27, 2016 at 02:38:50PM +0200, Benoit Fouet wrote:
> >>  h264_ps.c |   11 +++++++----
> >>  1 file changed, 7 insertions(+), 4 deletions(-)
> >>ea8cc471972e1dbaa4f4f03cd7a5fe92a3b848e9  0001-h264_ps-change-decode_scaling_matrices-so-that-it-ta.patch
> >> From c2606da98ecd04762305734f4f45ca8eaf266459 Mon Sep 17 00:00:00 2001
> >>From: Benoit Fouet <benoit.fouet at free.fr>
> >>Date: Mon, 27 Jun 2016 12:00:39 +0200
> >>Subject: [PATCH 1/3] h264_ps: change decode_scaling_matrices so that it takes
> >>  const {s,p}ps
> >>
> >>In order to be able to make SPS const in H264ParamSets,
> >>modify decode_scaling_matrices so that it returns if the scaling
> >>matrix are present in the SPS, instead of altering the input SPS
> >>structure.
> >>---
> >>  libavcodec/h264_ps.c | 11 +++++++----
> >>  1 file changed, 7 insertions(+), 4 deletions(-)
> >please document the return value
> >LGTM otherwise
> 
> See if attached patch is OK in that regard.
> 
> Thanks,
> 
> -- 
> Ben
> 

>  h264_ps.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 29b79e7890da03a59c4742e196ab018337950685  0001-h264_ps-change-decode_scaling_matrices-so-that-it-ta.patch
> From 67e714cbdabcb9ed808e8b10c70bbdf670cf3c2d Mon Sep 17 00:00:00 2001
> From: Benoit Fouet <benoit.fouet at free.fr>
> Date: Mon, 27 Jun 2016 12:00:39 +0200
> Subject: [PATCH 1/3] h264_ps: change decode_scaling_matrices so that it takes
>  const {s,p}ps
> 
> In order to be able to make SPS const in H264ParamSets,
> modify decode_scaling_matrices so that it returns if the scaling
> matrix are present in the SPS, instead of altering the input SPS
> structure.
> ---
>  libavcodec/h264_ps.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160629/be17a9a9/attachment.sig>