[FFmpeg-devel] [PATCH 3/3] lavfi: Move new field to the end of AVFilterContext

[Michael Niedermayer]

On Wed, Jun 29, 2016 at 02:43:52PM +0200, Timo Rothenpieler wrote:
> > This has to be documented in APIChanges i think
> 
> Adding that field was documented there originally.
> It came in as a merge from libav in 8688d3a, and should have been merged
> to the end of the struct there.
> Technically it was an ABI break, but nothing seems to be affected by it.
> 
> So I'm not exactly sure what to do about it.
> Moving it to the end now will break ffmpeg/ffplay built from 3.1.0 or
> current master when using libraries from 3.1.1 or post-merge master.
> 
> It might be better to fix this now before 3.1 gains wider adoption,
> maybe releasing 3.1.1 or even 3.1.0.1 a bit ahead of schedule.
> 

> Does it still need an APIChanges entry, even though the addition was
> already documented there and this is an ABI-Only change?

the pragmatic choice is certainly to document it somewhere

Distribution package maintainers who did package 3.1 need to know
there is a ABI fix in 3.1.1 so they can set depends & conflicts
accordingly, what they need to do is to make sure ffmpeg/ffplay 3.1
conflicts with libavfilter from 3.1.1

The ABI was defined by 3.0 and 3.1 should not have broken that, no
matter how slightly

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160629/d5dcbb66/attachment.sig>