[FFmpeg-devel] [PATCH][libavfilter] codecview: improved options

Moritz Barsnick barsnick at gmx.net
Sat May 7 23:26:16 CEST 2016


On Sat, May 07, 2016 at 19:48:31 +0000, Davinder Singh wrote:

> -    { "frames", "set frame types to display MVs of", OFFSET(frames), AV_OPT_TYPE_FLAGS, {.i64=3}, 0, INT_MAX, FLAGS, "frames" },
> +    { "frames", "set frame types to display MVs of", OFFSET(frames), AV_OPT_TYPE_FLAGS, {.i64=7}, 0, INT_MAX, FLAGS, "frames" },
                                                                                               ^
This could be written symbolically to make its value more obvious.

> -forward predicted MVs of P-frames
> +predicted frames (p-frames)
>  @item bf
> -forward predicted MVs of B-frames
> - at item bb
> -backward predicted MVs of B-frames
> +bi-directionally predicted frames (b-frames)

Didn't you just introduce capitalization of B and P in the 0002 patch,
and now drop it here?

> +        CONST("pf", "p-frames", FRAME_TYPE_P, "frames"),
> +        CONST("bf", "b-frames", FRAME_TYPE_B, "frames"),

Same here.

Moritz


More information about the ffmpeg-devel mailing list