[FFmpeg-devel] [PATCH v2] hevc: Fix memory leak related to a53_caption data

Michael Niedermayer michael at niedermayer.cc
Sun May 15 01:29:44 CEST 2016

On Tue, May 10, 2016 at 12:29:11PM -0500, Will Kelleher wrote:
> On 04/08, Will Kelleher wrote:
> > 
> > The leak is...continuous.  We only noticed it during long running decode
> > operations because the amount is small, but it definitely adds up.
> >
> Hi all,
> I finally got some time to revisit this.
> In the simple case where we are not decoding the HEVC bitstream, the
> parser never frees the caption data.  This patch adds a function
> similar to what the H.264 decoder is using to free SEI data. This
> gets called near the top of each parse_nal_units run to clear any
> SEI data from the previous picture.
> This is almost a copy-paste from the H.264 solution.
> I would love to get this in, because anyone using an HEVC input with
> bitstream caption data is going to see this leak.


you are still missing the error path at EOF case though i think
or is there some reason this wont lead to a leak ?

but the code thats added looks correct



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160515/d757916e/attachment.sig>

More information about the ffmpeg-devel mailing list