[FFmpeg-devel] [PATCH 1/2] avformat/movenc: propagate shift_data errors properly

Carl Eugen Hoyos cehoyos at ag.or.at
Sun May 29 18:16:56 CEST 2016


Marton Balint <cus <at> passwd.hu> writes:

> -            res = shift_data(s);
> +            if ((res = shift_data(s)) < 0)

It's not my code but "if (res < 0)" is imo easier to read, 
less error-prone and makes the patch smaller...

Carl Eugen



More information about the ffmpeg-devel mailing list