[FFmpeg-devel] [PATCH 2/2] avcodec/hap: add "compressor" option to Hap encoder to disable secondary compression

[Tom Butterworth]

Thanks Michael and Martin

I'll push this and offer a new patch with documentation for the Hap encoder
in doc/encoders.texi.

On Wed, 9 Nov 2016 at 07:37 Martin Vignali <martin.vignali at gmail.com> wrote:

> > >
> > > Maybe can be useful, to have a log,
> > > if chunk_count != 1 and compression is none, to show to the user, that
> > the
> > > chunk count option will be override by 1.
> > >
> >
> > The existing info log in hap_init() will print eg "6 chunks requested
> but 1
> > used." as is already done when the user's choice is overridden to divide
> > frames evenly. Is that sufficient or do you think a reason should be
> > displayed?
> >
>
> Yes you're right, the existing log, it's maybe enough.
> Like suggested by Michael, if it's documented in the encoders.texi, it can
> help user to know what settings have an impact on the result.
>
>
> >
> > Relative to this patch, with the none ( / snappy) parameter, libsnappy is
> > > not require for the entire encoder now,
> > > only when we set compression to snappy.
> > > Maybe can be useful to have something like in the tiffenc.c, where
> Zlib,
> > is
> > > required for only deflate compression).
> > >
> >
> > As Snappy is disabled by default, I think it would be a mistake to have
> the
> > default configuration of ffmpeg encode Hap without Snappy. Skipping the
> > Snappy compression stage is not generally desirable and it should not be
> > the default behaviour.
> >
>
> Yes, maybe don't output by default hap without snappy,  it's the best
> choice.
>
> Thanks
>
> Martin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>