[FFmpeg-devel] [PATCH 3/3] fate: Add h264 and hevc extradata reload tests

[Vittorio Giovara]

On Wed, Nov 9, 2016 at 4:11 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Tue, Nov 08, 2016 at 10:39:41PM -0500, Vittorio Giovara wrote:
>> On Tue, Nov 8, 2016 at 7:15 PM, Michael Niedermayer
>> <michael at niedermayer.cc> wrote:
>> > On Tue, Nov 08, 2016 at 05:03:28PM -0500, Vittorio Giovara wrote:
>> >> ---
>> >> Samples available at
>> >> - https://www.dropbox.com/s/gkswnubzy6e6rgg/h264-extradata-reload-multi-stsd.mov?dl=0
>> >> - https://www.dropbox.com/s/djfvoqgu2z9zrqu/hevc-extradata-reload-multi-stsd.mov?dl=0
>> >> They need to be renamed without the codec tag and placed in the appropriate
>> >> directory in fate.
>> >> Please CC.
>> >> Vittorio
>> >>
>> >>  tests/fate/h264.mak                  |  5 +++++
>> >>  tests/fate/hevc.mak                  |  5 +++++
>> >>  tests/ref/fate/h264-extradata-reload | 13 +++++++++++++
>> >>  tests/ref/fate/hevc-extradata-reload | 13 +++++++++++++
>> >>  4 files changed, 36 insertions(+)
>> >>  create mode 100644 tests/ref/fate/h264-extradata-reload
>> >>  create mode 100644 tests/ref/fate/hevc-extradata-reload
>> >
>> > doesnt seem to pass here
>> >
>> > --- ./tests/ref/fate/hevc-extradata-reload      2016-11-08 23:33:06.888177493 +0100
>> > +++ tests/data/fate/hevc-extradata-reload       2016-11-09 01:09:12.080298952 +0100
>> > @@ -9,5 +9,5 @@
>> >  #stream#, dts,        pts, duration,     size, hash
>> >  0,          0,          0,        1,    24576, 0d01217c5d1ec6799643fc7d75ba2337
>> >  0,          1,          1,        1,    24576, f73d9cca9b4c1765d0ead242c3f0c339
>> > -0,          2,          2,        1,    24576, 39a8714d763c623ae7f6faae34e107d1
>> > -0,          3,          3,        1,    24576, 5db2600aa268b4fd28b64ab28a096f32
>> > +0,          2,          2,        1,    24576, aea8b931d694e38ffa54ea4c88e04491
>> > +0,          3,          3,        1,    24576, 9d8f6a78c1bae37eabcab29295fd02a8
>>
>> Oh yeah, I ran the hashes with asm and optimizations disabled, if I do
>> enable them I get the new hashes too.
>> I tried to output the raw images but I can't see any difference, so
>> suspect there could be a lingering issue somewhere in the asm. Would
>> you be able to look into it?
>
> i would but my todo list is too long and growing, maybe someone else
> can help ?

I see, maybe the HEVC part could be stripped out and only the h264
test could be added?
It's good to test multiple stsd for h264 only anyway.

Off topic, what's the status of "mov: Evaluate the movie display
matrix"? I haven't received any more comments.
Please CC.
-- 
Vittorio