[FFmpeg-devel] [PATCH] doc/bsfs: various improvements

Moritz Barsnick barsnick at gmx.net
Wed Nov 16 01:11:50 EET 2016


On Tue, Nov 15, 2016 at 13:55:56 -0900, Lou Logan wrote:
> Fixes ticket #3198, but you don't need to send a new patch to mention
> that.

Ah, I wasn't even aware. Feel free to amend the commit message.

> LGTM, thanks. I'll wait a day or two if anyone else wants to comment
> before I push it.

I couldn't wrap my head around some of the filters. Sometimes, no other
mention is even found on the web (incl. mailing lists) except for e.g.
quotes of the sources. (I did try to reverse-engineer the sources
carefully.) I reckoned some doc is better than no doc.

E.g. I couldn't figure out whether all filters are "still" useful, or
whether documenting them may confuse someone. Was the MP3 header
compression, as once created by a now-removed bitstream filter,
proprietary to ffmpeg? Was it found in the wild? Or: What is the movsub
filter pair actually useful for?

I worry too much.

Thanks for the review,
Moritz


More information about the ffmpeg-devel mailing list