[FFmpeg-devel] [PATCH 1/3 v2] lavu: Add AVSphericalMapping type and frame side data

[Michael Niedermayer]

On Wed, Nov 16, 2016 at 02:39:30AM +0100, Michael Niedermayer wrote:
> On Tue, Nov 15, 2016 at 11:56:48AM -0500, Vittorio Giovara wrote:
> [...]
> > +/**
> > + * This structure describes how to handle spherical videos, outlining
> > + * information about projection, initial layout, and any other view modifier.
> > + *
> > + * @note The struct must be allocated with av_spherical_alloc() and
> > + *       its size is not a part of the public ABI.
> > + */
> > +typedef struct AVSphericalMapping {
> > +    /**
> > +     * Projection type.
> > +     */
> > +    enum AVSphericalProjection projection;
> > +
> > +    /**
> > +     * @name Initial orientation
> > +     * @{
> > +     * These fields represent the pose values that measure the rotation
> > +     * transformation (in degrees) to be applied to the projection.
> 
> > +     * They are exported as 16.16 fixed point.
> 
> why waste 7 bits of precission ?
> 
> something like
> value * 180.0 / INT32_MAX
> seems simpler
> the user can also then just do
> value * PI / INT32_MAX
> to get radians instead of degree
> (or similar with 360 and UINT32_MAX)

and of course i forgot to add the CC, mutt always removes it :(

[...]



-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161116/2e802ffb/attachment.sig>