[FFmpeg-devel] [PATCH] RTSP: pass TLS args for RTSPS

[Michael Niedermayer]

On Sat, Oct 15, 2016 at 08:31:23PM +0000, Jay wrote:
> Thank you for the feedback. I have been trying to get RTSPS cert validation
> incorporated for several weeks. I would greatly appreciate someone on the
> core team helping me guide this to completion. Please find your questions
> answered below.
> 
> > the get_file_handle extensions should be in a spererate patch than
> > the rtsp changes
> 
> I am process agnostic, but the RTSP changes are dependent on the TLS
> changes. There is a check for peer addr in RTSP that is based on the file
> descriptor.

The TLS changes do not depend on the RTSP changes, they can be in a
seperate patch, applied before. TLS and RTSP are seperate "modules"
changes to them are cleaner if split

> 
> > also is it safe for all to use the input file handle that way ?
> > for example if one used a fifo the input state would not match the
> > relevant output neccessarily
> 
> I do not think the peer addr check is necessary. My goal is a minimal
> patch, making RTSPS work with basic TLS options.

Is that the only use of the file handle ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161016/7a1b3011/attachment.sig>