[FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

[Nicolas George]

Le tridi 13 germinal, an CCXXV, Thomas Mundt a écrit :
> I found the use of this function in f_loop.c, so I thought it´s ok.

Well, it is a bug. I missed it when it was first committed.

> link->current_pts always returns the pts until the current (last) frame.
> I can calculate its duration for cfr video, but not for vfr. I need the pts until the virtual next frame.
> At which point in the code can I get it?

link->current_pts is updated when request_frame() returns EOF. But to
make it work, it would be necessary that the application injects the
timestamp when marking EOF, which is not yet done, but hopefully I will
have time to work on it in the next two weeks.

But it is the correct way of doing things. Using the duration has too
many drawbacks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170402/67a9ce5c/attachment.sig>