[FFmpeg-devel] [PATCH 2/2] lavf/tcp.c: Free allocated client URLContext in case of error.

[Stephan Holljes]

On Tue, Apr 11, 2017 at 7:24 PM, Nicolas George <george at nsup.org> wrote:
> Le duodi 22 germinal, an CCXXV, Stephan Holljes a écrit :
>> In fact the http patch introduces a bug where it closes the URLContext
>> regardless of ret. New patches shortly. (Also rebased on Simon's
>> patches fixing tcp return codes.)
>
> You are right, I missed that too.
>
> I suggest to add "return 0;" before "fail:", so that it is really only
> for failure.
>
> Regards,
>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

I like adding return 0 before fail, it saves a comparison. New patches shortly.

Regards