[FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

[Hendrik Leppkes]

On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson <alevinsn at aracnet.com> wrote:
> On 4/16/2017 1:33 PM, Timo Rothenpieler wrote:
>>>
>>> Thanks, applied.
>>>
>>> Regards,
>>> Marton
>>
>>
>> This seems to have broken the coverity builds:
>> https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds/222597943#L1103
>
>
> It was suggested on IRC by James Almer that "it seems to complain about
> ubitux's 'strict' pthread implementation (for assert levels above 0). Maybe
> it needs to be disabled for C++ sources."
>

The real problem is in av_err2str, which uses a temporary array, which
is either not valid in C++ (likely), or not supported by MSVC for
reasons (although in contrast to C support, its C++ support is
generally pretty good).
But considering how little C++ code we have, its probably best to
somehow avoid using it instead of trying to fix it.

- Hendrik