[FFmpeg-devel] [PATCH] Check return value of read in ff_rtsp_read_reply()

Daniel Richard G. skunk at iSKUNK.ORG
Mon Apr 17 08:12:21 EEST 2017


In the course of testing RTSP streaming of CCTV video via the FFmpeg
API, I have found some Valgrind uninitialized-memory errors due to what
appear to be short/failed reads in ffurl_read_complete().

The calling function ff_rtsp_read_reply() was not checking the return
value, and so the library went on to parse garbage in an
uninitialized heap-allocated buffer.

The attached patch adds logic to check the return value and bail
out on error.


--Daniel


-- 
Daniel Richard G. || skunk at iSKUNK.ORG
My ASCII-art .sig got a bad case of Times New Roman.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-return-value-of-read-in-ff_rtsp_read_reply.patch
Type: text/x-patch
Size: 966 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170417/c651439a/attachment.bin>


More information about the ffmpeg-devel mailing list