[FFmpeg-devel] [PATCH]lavf/mov: Only copy extradata if it exists.

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu Apr 20 00:40:11 EEST 2017


2017-04-18 16:33 GMT+02:00 Michael Niedermayer <michael at niedermayer.cc>:
> On Tue, Apr 18, 2017 at 10:59:31AM +0200, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch fixes an ubsan warning like the following here:
>> libavformat/mov.c:2332:13: runtime error: null pointer passed as argument 2,
>> which is declared to never be null
>>
>> Please comment, Carl Eugen
>
>>  mov.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 6e412b49316b5c6529c476233d54723c24b1d740  0001-lavf-mov-Only-copy-extradata-if-it-exists.patch
>> From b117fdd2adf3271fcaf8f9388866aaf115284f74 Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
>> Date: Tue, 18 Apr 2017 10:56:31 +0200
>> Subject: [PATCH] lavf/mov: Only copy extradata if it exists.
>>
>> Avoids undefined call of memcpy(ptr, NULL, 0);
>> ---
>>  libavformat/mov.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM

Patch applied.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list