[FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

[James Zern]

On Thu, Apr 20, 2017 at 3:06 PM, James Zern <jzern at google.com> wrote:
> On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> Hi,
>>
>> On Thu, Apr 20, 2017 at 2:42 PM, James Zern <jzern-at-google.com at ffmpeg.org>
>> wrote:
>>
>>> On Thu, Apr 13, 2017 at 6:44 PM, James Zern <jzern at google.com> wrote:
>>> > this was added in 1.6.0
>>> >
>>> > Signed-off-by: James Zern <jzern at google.com>
>>> > ---
>>> >  doc/encoders.texi      | 2 +-
>>> >  libavcodec/libvpxenc.c | 3 ++-
>>> >  2 files changed, 3 insertions(+), 2 deletions(-)
>>> >
>>>
>>> I'll submit this soon if there aren't any comments.
>>
>>
>> Looks good.
>>
>> (I'm guessing it doesn't need an ABI version check because it's
>> automatically clipped internally if you specify aq-mode=4 to an earlier
>> version of the library?)
>>
>
> Older libs will fail as it will exceed the range check. I debated an
> abi check, but that only pushes the range failure up to this level if
> we constrain the range.

Pushed with an abi check since control failures are non-fatal as
opposed to the range check in libvpxenc.