[FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

[Aurelien Jacobs]

On Mon, Nov 06, 2017 at 04:22:30AM +0100, Michael Niedermayer wrote:
> Hi 
> 
> On Mon, Nov 06, 2017 at 12:35:18AM +0100, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> >  doc/general.texi                 |   2 +
> >  libavcodec/Makefile              |   4 +
> >  libavcodec/allcodecs.c           |   2 +
> >  libavcodec/arm/Makefile          |   3 +
> >  libavcodec/arm/sbcdsp_armv6.S    | 245 ++++++++++++++
> >  libavcodec/arm/sbcdsp_init_arm.c | 105 ++++++
> >  libavcodec/arm/sbcdsp_neon.S     | 714 +++++++++++++++++++++++++++++++++++++++
> >  libavcodec/avcodec.h             |   2 +
> >  libavcodec/codec_desc.c          |  12 +
> >  libavcodec/sbc.c                 | 316 +++++++++++++++++
> >  libavcodec/sbc.h                 | 121 +++++++
> >  libavcodec/sbcdec.c              | 469 +++++++++++++++++++++++++
> >  libavcodec/sbcdec_data.c         | 127 +++++++
> >  libavcodec/sbcdec_data.h         |  44 +++
> >  libavcodec/sbcdsp.c              | 569 +++++++++++++++++++++++++++++++
> >  libavcodec/sbcdsp.h              |  86 +++++
> >  libavcodec/sbcdsp_data.c         | 335 ++++++++++++++++++
> >  libavcodec/sbcdsp_data.h         |  57 ++++
> >  libavcodec/sbcenc.c              | 461 +++++++++++++++++++++++++
> >  libavcodec/x86/Makefile          |   2 +
> >  libavcodec/x86/sbcdsp.asm        | 290 ++++++++++++++++
> >  libavcodec/x86/sbcdsp_init.c     |  51 +++
> >  22 files changed, 4017 insertions(+)
> >  create mode 100644 libavcodec/arm/sbcdsp_armv6.S
> >  create mode 100644 libavcodec/arm/sbcdsp_init_arm.c
> >  create mode 100644 libavcodec/arm/sbcdsp_neon.S
> >  create mode 100644 libavcodec/sbc.c
> >  create mode 100644 libavcodec/sbc.h
> >  create mode 100644 libavcodec/sbcdec.c
> >  create mode 100644 libavcodec/sbcdec_data.c
> >  create mode 100644 libavcodec/sbcdec_data.h
> >  create mode 100644 libavcodec/sbcdsp.c
> >  create mode 100644 libavcodec/sbcdsp.h
> >  create mode 100644 libavcodec/sbcdsp_data.c
> >  create mode 100644 libavcodec/sbcdsp_data.h
> >  create mode 100644 libavcodec/sbcenc.c
> >  create mode 100644 libavcodec/x86/sbcdsp.asm
> >  create mode 100644 libavcodec/x86/sbcdsp_init.c
> 
> this seems to fail to build on x86-32

Ooops... Haven't use x86-32 for so long that it didn't even occured to
me to test it.

>         libavcodec/x86/sbcdsp_init.o
> src/libavcodec/x86/sbcdsp.asm:251: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:264: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:267: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:269: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:270: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:271: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:273: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:274: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:275: error: invalid operands in non-64-bit mode
> src/libavcodec/x86/sbcdsp.asm:276: error: invalid operands in non-64-bit mode
> STRIP   libavcodec/x86/opus_pvq_search.o

Fixed in upcoming patchset.