[FFmpeg-devel] [PATCH] avcodec/h264_ps: Check chroma_qp_index_offset

[Paul B Mahol]

On 2/22/17, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Wed, Feb 22, 2017 at 04:41:43PM +0100, Paul B Mahol wrote:
>> On 2/22/17, Michael Niedermayer <michael at niedermayer.cc> wrote:
>> > On Wed, Feb 22, 2017 at 02:29:00PM +0100, Paul B Mahol wrote:
>> >> On 2/22/17, Michael Niedermayer <michael at niedermayer.cc> wrote:
>> >> > Fixes: 647/clusterfuzz-testcase-5195745823031296
>> >> >
>> >> > Found-by: continuous fuzzing process
>> >> > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
>> >> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>> >> > ---
>> >> >  libavcodec/h264_ps.c | 11 +++++++++++
>> >> >  1 file changed, 11 insertions(+)
>> >> >
>> >> > diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
>> >> > index 8090178395..f4a4a01fbe 100644
>> >> > --- a/libavcodec/h264_ps.c
>> >> > +++ b/libavcodec/h264_ps.c
>> >> > @@ -828,6 +828,12 @@ int
>> >> > ff_h264_decode_picture_parameter_set(GetBitContext
>> >> > *gb, AVCodecContext *avct
>> >> >      pps->init_qp                              = get_se_golomb(gb) +
>> >> > 26
>> >> > +
>> >> > qp_bd_offset;
>> >> >      pps->init_qs                              = get_se_golomb(gb) +
>> >> > 26
>> >> > +
>> >> > qp_bd_offset;
>> >> >      pps->chroma_qp_index_offset[0]            = get_se_golomb(gb);
>> >> > +    if (pps->chroma_qp_index_offset[0] < -12 ||
>> >> > pps->chroma_qp_index_offset[0] > 12) {
>> >> > +        av_log(avctx, AV_LOG_ERROR, "chroma_qp_index_offset[0] %d
>> >> > is
>> >>
>> >> This is nonsense. Please remove.
>> >
>> > Id like to keep the error messages or id like to have someone else
>> > take over h264 maintaince in ffmpeg.
>>
>> Than why you are posting patches at all, if you do not want to listen
>> to reviews.
>
> ive posted a patchset with ff_elog() instead
>
> do people prefer that ?
>
> [...]

You could right now start adding such messages at every error path.