[FFmpeg-devel] [PATCH 17/17] lavfi/buffersink: move to the new design.

Rostislav Pehlivanov atomnuker at gmail.com
Thu Jan 5 12:51:56 EET 2017


On 5 January 2017 at 10:27, Nicolas George <george at nsup.org> wrote:

> Le nonidi 9 nivôse, an CCXXV, Nicolas George a écrit :
> > Signed-off-by: Nicolas George <george at nsup.org>
> > ---
> >  libavfilter/buffersink.c | 214 +++++++++++++-----------------
> -----------------
> >  1 file changed, 56 insertions(+), 158 deletions(-)
> >
> >
> > Minor changes to accomodate the previous changes. Since diff is not very
> > smart about it, better read the code than the patch.
>
> This patch and the previous one still lack a review.
>
> For convenience, here is an excerpt of the file after the patch
> containing the parts that are mostly rewritten and unreadable with diff.
>
> Regards,
>
> --
>   Nicolas George
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
Thanks, the excerpt looks fine to me.

btw, there's apparently been a regression w.r.t. EOF handling which wm4
hasn't told you about yet, not sure which commit introduced it though:

https://github.com/mpv-player/mpv/commit/43386a7c92e14e56abdebfd4ed9335794c795f2b


More information about the ffmpeg-devel mailing list