[FFmpeg-devel] [PATCH] avformat/matroskaenc: Accept time base hint

Michael Niedermayer michaelni at gmx.at
Sat Jan 14 13:59:04 EET 2017


On Fri, Jan 13, 2017 at 08:48:01AM -0800, Michael Bradshaw wrote:
> On Wed, Dec 28, 2016 at 5:03 AM, Michael Niedermayer <michael at niedermayer.cc
> > wrote:
> 
> > On Tue, Dec 27, 2016 at 09:47:47PM -0800, Michael Bradshaw wrote:
> > > From: Michael Bradshaw <mjbshaw at google.com>
> > >
> > > Signed-off-by: Michael Bradshaw <mjbshaw at google.com>
> > > ---
> > >  libavformat/matroskaenc.c | 38 +++++++++++++++++++++++++++++++-------
> > >  1 file changed, 31 insertions(+), 7 deletions(-)
> >
> > breaks fate
> > [...]
> 
> 
> I've looked into this and it's expected behavior. -codec copy is also
> copying timing information (including time base), and with this patch the
> Matroska/WebM muxers are respecting that.
> 

> I could update the fate files, but before doing that I'd like to ensure
> that this change in behavior for -codec copy is correct and desirable.

i think the patch is a good idea it has some other issues though (see
the other mail in this thread i just posted)

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170114/7adbe815/attachment.sig>


More information about the ffmpeg-devel mailing list