[FFmpeg-devel] [PATCH 2/3] avformat/avienc: add reserve_index_space option

[Michael Niedermayer]

On Mon, Jan 23, 2017 at 11:12:13AM +0100, Tobias Rapp wrote:
[...]
>  libavformat/avi.h                       |    1
>  libavformat/avienc.c                    |   77 +++++++++++++++++++++++++++++---
>  libavformat/version.h                   |    2 
>  tests/ref/fate/mpeg4-bsf-unpack-bframes |    2 
>  tests/ref/lavf-fate/avi_cram            |    2 
>  5 files changed, 74 insertions(+), 10 deletions(-)
> 8dfa5b4ff26ee67c6772bb257a772672bb91aa34  0002-avformat-avienc-add-reserve_index_space-option.patch
> From 4cc70ffdeb7eeb60e7bbb725bd5885dcacf968d2 Mon Sep 17 00:00:00 2001
> From: Tobias Rapp <t.rapp at noa-archive.com>
> Date: Wed, 4 Jan 2017 15:31:29 +0100
> Subject: [PATCH 2/3] avformat/avienc: add reserve_index_space option
> 
> Allows the user to reserve space for the ODML master index. A sufficient
> sized master index in the AVI header avoids storing follow-up master
> indexes within the 'movi' data later.
> 
> If the option is omitted or zero the index size is estimated from output
> duration and bitrate. A worst-case bitrate for video streams is assumed
> in case it is not available.
> 

> Note: fate reference files changed because the video stream had zero
> bitrate before and is guessed now.

I dont think this is good
if the user app says bitrate is 0 the muxer should not replace that by
the bitrate for a rawvideo stream (when its not rawvideo)

This could be ok for the reserved space calculation but for the file
bitrate, especially with lossy compressed streams this will likely
give values that are less correct than before

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170125/7283f824/attachment.sig>