[FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

Paul B Mahol onemda at gmail.com
Sun Jan 29 01:26:55 EET 2017


On 1/29/17, Andreas Cadhalpun <andreas.cadhalpun at googlemail.com> wrote:
> On 28.01.2017 12:44, Marton Balint wrote:
>> If we reduce the number of extra lines (not at any cost), I think that
>> helps.
>> There is also a solution which keeps the traditional C syntax, and is easy
>> to undestand even at first glance.
>>
>> if (st->codecpar->channels > FF_SANE_NB_CHANNELS)
>>     return ff_elog(AVERROR(ENOSYS), s, "Too many channels %d > %d\n",
>> st->codecpar->channels, FF_SANE_NB_CHANNELS);
>
> How would you define ff_elog for this to work?

I'm maintainer of this file, and I'm fed up with this nuisance conversation.
I'm against log message.


More information about the ffmpeg-devel mailing list