[FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

[Ronald S. Bultje]

Hi Wan-Teh,

On Wed, Jul 5, 2017 at 6:12 PM, Wan-Teh Chang <wtc at google.com> wrote:

> Hi Ronald,
>
> Thank you for the quick reply!
>
> On Wed, Jul 5, 2017 at 2:49 PM, Ronald S. Bultje <rsbultje at gmail.com>
> wrote:
> > Hi Wan-Teh,
> >
> > On Wed, Jul 5, 2017 at 5:30 PM, Wan-Teh Chang <wtc at google.com> wrote:
> >>
> >> Hi Ronald,
> >>
> >> A variant of this patch is committed as
> >> 2e664b9c1e73c80aab91070c1eb7676f04bdd12d:
> >>
> >> http://ffmpeg.org/pipermail/ffmpeg-cvslog/2017-April/106577.html
> >>
> >> I believe it does not fix the tsan warning.
> >
> > I had noticed that too.
> >
> > Unfortunately, I have spent a significant amount of (unpaid, personal)
> time
> > on fixing most of these tsan warnings already (with help of ubitux -
> > thanks!!), and given the incredibly mega-low impact of this particular
> > outstanding issue, I'm currently not actively working on fixing this. I
> may
> > get back to this issue later but I have some other things that I'd rather
> > work on and that I believe are more important.
>
> Thank you for all the tsan warning fixes. In the meantime, it would be
> good to revert 2e664b9c1e73c80aab91070c1eb7676f04bdd12d to avoid
> confusion.


Why? I believe it fixes a subset of the issue.

Ronald