[FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

[Derek Buitenhuis]

On 7/16/2017 1:29 PM, Ronald S. Bultje wrote:
> Pushed.
> 
> Ronald

I am going to quote myself here, because it was never address, was not even
replied to, and is outright incorrect on some OSes:

>> +enabled libvmaf           && { check_lib libvmaf "libvmaf.h" "compute_vmaf" -lvmaf -lstdc++ -lpthread -lm ||
>> +                               die "ERROR: libvmaf must be installed"; }
> 
> This won't work on, for example, OS X, which uses libc++ instead of libstdc++.
> It'll also add extra unneeded libs to the linker flags when libvmaf is built
> as a hared library,
> 
> The correct solution is for libvmaf to provide a proper pkg-config file.

Students should learn to reply to reviews instead of sending new patches
with no changelog and having them pushed anyway.

- Derek