[FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

[Tobias Rapp]

On 19.07.2017 17:06, Nicolas George wrote:
> Le primidi 1er thermidor, an CCXXV, Tobias Rapp a écrit :
>> Indeed they are remainders from previous edits. It seems that stripping any
>> whitespace within the filter string is enough to ensure that it is passed as
>> one argument token to ffmpeg. So fixed locally.
>
> I suppose you left the quotes, otherwise the semicolon separates
> commands and the brackets are globbing patterns.

Indeed, see attached patch for reference (WIP as it still contains the 
CPUFLAGS work-around).

>>>> +	-f null /dev/null
>> BTW: Is it OK to redirect output to "/dev/null" here or does this introduce
>> an unwanted platform dependency (i.e. blocks FATE from running on
>> MSYS/Windows)?
>
> With -f null, you can put anything you want there. I usually put -, but
> that is just a convenience to be able to change it to "-f fmt - | cmd".

OK.

Regards,
Tobias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fate-add-tests-for-psnr-and-ssim-filter.patch
Type: text/x-patch
Size: 7182 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170719/711e0c44/attachment.bin>